From 071a008cf28e733ca3aaafa57e675fd54a5ea33b Mon Sep 17 00:00:00 2001
From: Roberto Sánchez <roberto.sanchez@curisit.net>
Date: Fri, 19 Sep 2014 09:29:16 +0000
Subject: [PATCH] #396 fix - Fixed more SonarQube issues, new code style applied

---
 securis/src/main/java/net/curisit/securis/services/ApplicationResource.java |   27 +++++++++++++++++++--------
 1 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/securis/src/main/java/net/curisit/securis/services/ApplicationResource.java b/securis/src/main/java/net/curisit/securis/services/ApplicationResource.java
index 1e7230d..d6079e9 100644
--- a/securis/src/main/java/net/curisit/securis/services/ApplicationResource.java
+++ b/securis/src/main/java/net/curisit/securis/services/ApplicationResource.java
@@ -27,8 +27,8 @@
 import net.curisit.securis.db.Application;
 import net.curisit.securis.utils.TokenHelper;
 
-import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 import com.google.inject.persist.Transactional;
 
@@ -49,7 +49,8 @@
 
     private static final Logger LOG = LogManager.getLogger(ApplicationResource.class);
 
-    public ApplicationResource() {}
+    public ApplicationResource() {
+    }
 
     /**
      * 
@@ -57,7 +58,9 @@
      */
     @GET
     @Path("/")
-    @Produces({ MediaType.APPLICATION_JSON })
+    @Produces({
+        MediaType.APPLICATION_JSON
+    })
     public Response index() {
         LOG.info("Getting applications list ");
 
@@ -74,7 +77,9 @@
      */
     @GET
     @Path("/{appid}")
-    @Produces({ MediaType.APPLICATION_JSON })
+    @Produces({
+        MediaType.APPLICATION_JSON
+    })
     public Response get(@PathParam("appid") String appid, @HeaderParam(TokenHelper.TOKEN_HEADER_PÀRAM) String token) {
         LOG.info("Getting application data for id: {}: ", appid);
         if (appid == null || "".equals(appid)) {
@@ -96,7 +101,9 @@
     @POST
     @Path("/")
     @Consumes(MediaType.APPLICATION_JSON)
-    @Produces({ MediaType.APPLICATION_JSON })
+    @Produces({
+        MediaType.APPLICATION_JSON
+    })
     @Transactional
     public Response create(Application app, @HeaderParam(TokenHelper.TOKEN_HEADER_PÀRAM) String token) {
         LOG.info("Creating new application");
@@ -112,7 +119,9 @@
     @Path("/{appid}")
     @Transactional
     @Consumes(MediaType.APPLICATION_JSON)
-    @Produces({ MediaType.APPLICATION_JSON })
+    @Produces({
+        MediaType.APPLICATION_JSON
+    })
     public Response modify(Application app, @PathParam("appid") String appid, @HeaderParam(TokenHelper.TOKEN_HEADER_PÀRAM) String token) {
         LOG.info("Modifying application with id: {}", appid);
         EntityManager em = emProvider.get();
@@ -132,7 +141,9 @@
     @DELETE
     @Path("/{appid}")
     @Transactional
-    @Produces({ MediaType.APPLICATION_JSON })
+    @Produces({
+        MediaType.APPLICATION_JSON
+    })
     public Response delete(@PathParam("appid") String appid, @Context HttpServletRequest request) {
         LOG.info("Deleting app with id: {}", appid);
         EntityManager em = emProvider.get();
@@ -143,7 +154,7 @@
                     .build();
         }
 
-        if (app.getLicenseTypes() != null && app.getLicenseTypes().size() > 0) {
+        if (app.getLicenseTypes() != null && !app.getLicenseTypes().isEmpty()) {
             return Response
                     .status(Status.FORBIDDEN)
                     .header(DefaultExceptionHandler.ERROR_MESSAGE_HEADER,

--
Gitblit v1.3.2