From 52ce72b22ef8d92a1f35b4993bcddaaa66d67350 Mon Sep 17 00:00:00 2001
From: Roberto Sánchez <roberto.sanchez@curisit.net>
Date: Thu, 18 Sep 2014 17:55:35 +0000
Subject: [PATCH] #396 fix - Fixed some SonarQube issues

---
 securis/src/main/java/net/curisit/securis/services/LicenseServices.java |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/securis/src/main/java/net/curisit/securis/services/LicenseServices.java b/securis/src/main/java/net/curisit/securis/services/LicenseServices.java
index 4a146f9..1eab294 100644
--- a/securis/src/main/java/net/curisit/securis/services/LicenseServices.java
+++ b/securis/src/main/java/net/curisit/securis/services/LicenseServices.java
@@ -33,7 +33,7 @@
 public class LicenseServices {
 
 	// private LicenseHelper licenseHelper = InjectorFactory.getInjector().getInstance(LicenseHelper.class);
-	private static final Logger log = LogManager.getLogger(LicenseServices.class);
+	private static final Logger LOG = LogManager.getLogger(LicenseServices.class);
 
 	private static final int DEFAULT_LICENSE_EXPIRATION = 365;
 	private static final String LICENSE_STRING = "CurisIntegrity Config Server v{0}.{1}";
@@ -58,8 +58,7 @@
 			String index = IOUtils.toString(this.getClass().getResourceAsStream("/static/index.html"));
 			return Response.ok().entity(index).build();
 		} catch (IOException e) {
-			// TODO Auto-generated catch block
-			e.printStackTrace();
+			LOG.error("Error getting index.html", e);
 		}
 		return Response.ok().entity(MessageFormat.format(LICENSE_STRING, 0, 1)).build();
 	}
@@ -69,7 +68,7 @@
 	@Produces(
 		{ MediaType.TEXT_PLAIN })
 	public Response dummy(@Context HttpServletRequest request) {
-		log.info("Request: " + request.getPathInfo());
+		LOG.info("Request: " + request.getPathInfo());
 		return Response.ok().entity((uri == null)).build();
 	}
 
@@ -82,7 +81,7 @@
 	@Produces(
 		{ MediaType.APPLICATION_JSON })
 	public Response testFile1(@MultipartForm FileUploadForm mfdi) {
-		log.info("FORM: texto: {}, file: {}", mfdi.getTexto(), new String(mfdi.getFile()));
+		LOG.info("FORM: texto: {}, file: {}", mfdi.getTexto(), new String(mfdi.getFile()));
 		return Response.ok("OK").build();
 	}
 
@@ -92,7 +91,7 @@
 		{ MediaType.APPLICATION_JSON })
 	public ServiceResponse<ServerConfigVersions> testFile(@PathParam("license") String license, @DefaultValue("-1") @QueryParam("minorVersion") int minorVersion, @DefaultValue("-1") @QueryParam("majorVersion") int majorVersion) {
 
-		log.info("Called 'current' service with license: {}", license);
+		LOG.info("Called 'current' service with license: {}", license);
 		ServiceResponse<ServerConfigVersions> response = new ServiceResponse<ServerConfigVersions>();
 
 		return response;

--
Gitblit v1.3.2